pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add compute_query_id = regress
Date: Tue, 22 Feb 2022 01:25:00 +0000
Message-ID: <E1nMJvI-0003xf-Ih@gemulon.postgresql.org> (raw)

Add compute_query_id = regress

"regress" is a new mode added to compute_query_id aimed at facilitating
regression testing when a module computing query IDs is loaded into the
backend, like pg_stat_statements.  It works the same way as "auto",
meaning that query IDs are computed if a module enables it, except that
query IDs are hidden in EXPLAIN outputs to ensure regression output
stability.

Like any GUCs of the kind (force_parallel_mode, etc.), this new
configuration can be added to an instance's postgresql.conf, or just
passed down with PGOPTIONS at command level.  compute_query_id uses an
enum for its set of option values, meaning that this addition ensures
ABI compatibility.

Using this new configuration mode allows installcheck-world to pass when
running the tests on an instance with pg_stat_statements enabled,
stabilizing the test output while checking the paths doing query ID
computations.

Reported-by: Anton Melnikov
Reviewed-by: Julien Rouhaud
Discussion: https://postgr.es/m/1634283396.372373993@f75.i.mail.ru
Discussion: https://postgr.es/m/YgHlxgc/OimuPYhH@paquier.xyz
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ebf6c5249b7db525e59563fb149642665c88f747

Modified Files
--------------
doc/src/sgml/config.sgml        | 7 +++++--
src/backend/commands/explain.c  | 8 +++++++-
src/backend/utils/misc/guc.c    | 1 +
src/include/utils/queryjumble.h | 3 ++-
4 files changed, 15 insertions(+), 4 deletions(-)



view thread (2+ messages)

Message-ID: <E1nMJvI-0003xf-Ih@gemulon.postgresql.org>
Permalink:  ../E1nMJvI-0003xf-Ih@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nMJvI-0003xf-Ih@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Add compute_query_id = regress
  In-Reply-To: <E1nMJvI-0003xf-Ih@gemulon.postgresql.org>
  References: <E1nMJvI-0003xf-Ih@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox