pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Re-allow underscore as first character of custom GUC names.
Date: Wed, 23 Feb 2022 16:10:53 +0000
Message-ID: <E1nMuEA-000Ipc-Fb@gemulon.postgresql.org> (raw)

Re-allow underscore as first character of custom GUC names.

Commit 3db826bd5 intended that valid_custom_variable_name's
rules for valid identifiers match those of scan.l.  However,
I (tgl) had some kind of brain fade and put "_" in the wrong
list.

Fix by Japin Li, per bug #17415 from Daniel Polski.

Discussion: https://postgr.es/m/17415-ebdb683d7e09a51c@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/dd7c0597918a6922a43a1f2e7085e6276a6216ec

Modified Files
--------------
src/backend/utils/misc/guc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1nMuEA-000Ipc-Fb@gemulon.postgresql.org>
Permalink:  ../E1nMuEA-000Ipc-Fb@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nMuEA-000Ipc-Fb@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Re-allow underscore as first character of custom GUC names.
  In-Reply-To: <E1nMuEA-000Ipc-Fb@gemulon.postgresql.org>
  References: <E1nMuEA-000Ipc-Fb@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox