From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: vacuumlazy.c: Remove obsolete num_tuples field.
Date: Fri, 25 Feb 2022 03:02:35 +0000
Message-ID: <E1nNQsM-000Fho-LI@gemulon.postgresql.org> (raw)
vacuumlazy.c: Remove obsolete num_tuples field.
Commit 49c9d9fc unified VACUUM VERBOSE and autovacuum logging. It
neglected to remove an old vacrel field that was only used by the old
VACUUM VERBOSE, so remove it now.
The previous num_tuples approach doesn't seem to have any real advantage
over the approach VACUUM VERBOSE takes now (also the approach used by
the autovacuum logging code), which is to show new_rel_tuples.
new_rel_tuples is the possibly-estimated total number of tuples left in
the table, whereas num_tuples meant the number of tuples encountered
during the VACUUM operation, after pruning, without regard for tuples
from pages skipped via the visibility map.
In passing, reorder a related vacrel field for consistency.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/73c61a50a1555007001d29844dcdb10b4f982a73
Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 27 ++++++++-------------------
1 file changed, 8 insertions(+), 19 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: pg@bowt.ie
Subject: Re: pgsql: vacuumlazy.c: Remove obsolete num_tuples field.
In-Reply-To: <E1nNQsM-000Fho-LI@gemulon.postgresql.org>
References: <E1nNQsM-000Fho-LI@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox