pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL
5+ messages / 1 participants
[nested] [flat]

* pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL
@ 2022-02-25 18:48  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 5+ messages in thread

From: Andres Freund @ 2022-02-25 18:48 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_waldump: Fix error message for WAL files smaller than XLOG_BLCKSZ.

When opening a WAL file smaller than XLOG_BLCKSZ (e.g. 0 bytes long) while
determining the wal_segment_size, pg_waldump checked errno, despite errno not
being set by the short read. Resulting in a bogus error message.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220214.181847.775024684568733277.horikyota.ntt@gmail.com
Backpatch: 11-, the bug was introducedin fc49e24fa

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cd83cb953606b94966981056e79dbb6c48751055

Modified Files
--------------
src/bin/pg_waldump/pg_waldump.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL
@ 2022-02-25 18:48  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 5+ messages in thread

From: Andres Freund @ 2022-02-25 18:48 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_waldump: Fix error message for WAL files smaller than XLOG_BLCKSZ.

When opening a WAL file smaller than XLOG_BLCKSZ (e.g. 0 bytes long) while
determining the wal_segment_size, pg_waldump checked errno, despite errno not
being set by the short read. Resulting in a bogus error message.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220214.181847.775024684568733277.horikyota.ntt@gmail.com
Backpatch: 11-, the bug was introducedin fc49e24fa

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0b1020a96d8e14ba5c5fe22f825c3093160aa83b

Modified Files
--------------
src/bin/pg_waldump/pg_waldump.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL
@ 2022-02-25 18:48  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 5+ messages in thread

From: Andres Freund @ 2022-02-25 18:48 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_waldump: Fix error message for WAL files smaller than XLOG_BLCKSZ.

When opening a WAL file smaller than XLOG_BLCKSZ (e.g. 0 bytes long) while
determining the wal_segment_size, pg_waldump checked errno, despite errno not
being set by the short read. Resulting in a bogus error message.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220214.181847.775024684568733277.horikyota.ntt@gmail.com
Backpatch: 11-, the bug was introducedin fc49e24fa

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5407241a8ec1af770010d05715f0e3a31db5c518

Modified Files
--------------
src/bin/pg_waldump/pg_waldump.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL
@ 2022-02-25 18:48  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 5+ messages in thread

From: Andres Freund @ 2022-02-25 18:48 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_waldump: Fix error message for WAL files smaller than XLOG_BLCKSZ.

When opening a WAL file smaller than XLOG_BLCKSZ (e.g. 0 bytes long) while
determining the wal_segment_size, pg_waldump checked errno, despite errno not
being set by the short read. Resulting in a bogus error message.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220214.181847.775024684568733277.horikyota.ntt@gmail.com
Backpatch: 11-, the bug was introducedin fc49e24fa

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9ff7fd9063ce918e458a643b53eda1cf95f7d115

Modified Files
--------------
src/bin/pg_waldump/pg_waldump.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL
@ 2022-02-25 18:48  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 5+ messages in thread

From: Andres Freund @ 2022-02-25 18:48 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_waldump: Fix error message for WAL files smaller than XLOG_BLCKSZ.

When opening a WAL file smaller than XLOG_BLCKSZ (e.g. 0 bytes long) while
determining the wal_segment_size, pg_waldump checked errno, despite errno not
being set by the short read. Resulting in a bogus error message.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220214.181847.775024684568733277.horikyota.ntt@gmail.com
Backpatch: 11-, the bug was introducedin fc49e24fa

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/51c34165614bde5d44a356ba5f1f4f79d8893103

Modified Files
--------------
src/bin/pg_waldump/pg_waldump.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2022-02-25 18:48 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-02-25 18:48 pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL Andres Freund <andres@anarazel.de>
2022-02-25 18:48 pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL Andres Freund <andres@anarazel.de>
2022-02-25 18:48 pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL Andres Freund <andres@anarazel.de>
2022-02-25 18:48 pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL Andres Freund <andres@anarazel.de>
2022-02-25 18:48 pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL Andres Freund <andres@anarazel.de>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox