From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL
Date: Fri, 25 Feb 2022 18:48:41 +0000
Message-ID: <E1nNfdw-000LaP-O2@gemulon.postgresql.org> (raw)
pg_waldump: Fix error message for WAL files smaller than XLOG_BLCKSZ.
When opening a WAL file smaller than XLOG_BLCKSZ (e.g. 0 bytes long) while
determining the wal_segment_size, pg_waldump checked errno, despite errno not
being set by the short read. Resulting in a bogus error message.
Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220214.181847.775024684568733277.horikyota.ntt@gmail.com
Backpatch: 11-, the bug was introducedin fc49e24fa
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9ff7fd9063ce918e458a643b53eda1cf95f7d115
Modified Files
--------------
src/bin/pg_waldump/pg_waldump.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de
Subject: Re: pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL
In-Reply-To: <E1nNfdw-000LaP-O2@gemulon.postgresql.org>
References: <E1nNfdw-000LaP-O2@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox