From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't use static storage for SaveTransactionCharacteristics().
Date: Mon, 28 Feb 2022 17:54:18 +0000
Message-ID: <E1nOkDy-000Jom-A8@gemulon.postgresql.org> (raw)
Don't use static storage for SaveTransactionCharacteristics().
This is pretty queasy-making on general principles, and the more so
once you notice that CommitTransactionCommand() is actually stomping
on the values saved by _SPI_commit(). It's okay as long as the
active values didn't change during HoldPinnedPortals(); but that's
a larger assumption than I think we want to make, especially since
the fix is so simple.
Discussion: https://postgr.es/m/1533956.1645731245@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/12d768e70497afc5a57acf73c251316997b5175a
Modified Files
--------------
src/backend/access/transam/xact.c | 32 ++++++++++++++------------------
src/backend/executor/spi.c | 16 ++++++++--------
src/include/access/xact.h | 12 ++++++++++--
3 files changed, 32 insertions(+), 28 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Don't use static storage for SaveTransactionCharacteristics().
In-Reply-To: <E1nOkDy-000Jom-A8@gemulon.postgresql.org>
References: <E1nOkDy-000Jom-A8@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox