pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix catalog data of pg_stop_backup(), labelled v2
Date: Thu, 03 Mar 2022 01:53:00 +0000
Message-ID: <E1nPaeK-000f8H-AQ@gemulon.postgresql.org> (raw)

Fix catalog data of pg_stop_backup(), labelled v2

This function has been incorrectly marked as a set-returning function
with prorows (estimated number of rows) set to 1 since its creation in
7117685, that introduced non-exclusive backups.  There is no need for
that as the function is designed to return only one tuple.

This commit fixes the catalog definition of pg_stop_backup_v2() so as it
is not marked as proretset anymore, with prorows set to 0.  This
simplifies its internals by removing one tuplestore (used for one single
record anyway) and by removing all the checks related to a set-returning
function.

Issue found during my quest to simplify some of the logic used in
in-core system functions.

Bump catalog version.

Reviewed-by: Aleksander Alekseev, Kyotaro Horiguchi
Discussion: https://postgr.es/m/Yh8guT78f1Ercfzw@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/62ce0c758d5d66092efbca7d037233e2ca9bdc78

Modified Files
--------------
src/backend/access/transam/xlogfuncs.c   | 36 ++++++--------------------------
src/backend/catalog/system_functions.sql |  2 +-
src/include/catalog/catversion.h         |  2 +-
src/include/catalog/pg_proc.dat          |  6 +++---
4 files changed, 11 insertions(+), 35 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1nPaeK-000f8H-AQ@gemulon.postgresql.org>
Permalink:  ../E1nPaeK-000f8H-AQ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nPaeK-000f8H-AQ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Fix catalog data of pg_stop_backup(), labelled v2
  In-Reply-To: <E1nPaeK-000f8H-AQ@gemulon.postgresql.org>
  References: <E1nPaeK-000f8H-AQ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox