pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix pg_regress to print the correct postmaster address on Window
Date: Fri, 04 Mar 2022 18:24:12 +0000
Message-ID: <E1nQCb6-000vvA-4L@gemulon.postgresql.org> (raw)

Fix pg_regress to print the correct postmaster address on Windows.

pg_regress reported "Unix socket" as the default location whenever
HAVE_UNIX_SOCKETS is defined.  However, that's not been accurate
on Windows since 8f3ec75de.  Update this logic to match what libpq
actually does now.

This is just cosmetic, but still it's potentially misleading.
Back-patch to v13 where 8f3ec75de came in.

Discussion: https://postgr.es/m/3894060.1646415641@sss.pgh.pa.us

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/59392746cb3fd3c23b5f7bfa9568a71705ca30d1

Modified Files
--------------
src/interfaces/libpq/fe-connect.c |  5 +++++
src/test/regress/pg_regress.c     | 10 ++++++++--
2 files changed, 13 insertions(+), 2 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1nQCb6-000vvA-4L@gemulon.postgresql.org>
Permalink:  ../E1nQCb6-000vvA-4L@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nQCb6-000vvA-4L@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix pg_regress to print the correct postmaster address on Window
  In-Reply-To: <E1nQCb6-000vvA-4L@gemulon.postgresql.org>
  References: <E1nQCb6-000vvA-4L@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox