pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make the errcontext message in logical replication worker transl
Date: Mon, 07 Mar 2022 03:27:35 +0000
Message-ID: <E1nR423-001HH4-31@gemulon.postgresql.org> (raw)

Make the errcontext message in logical replication worker translation friendly.

Previously, the message for logical replication worker errcontext is
incrementally built, which was not translation friendly.  Instead, we use
complete sentences with if-else branches.

We also remove the commit timestamp from the context message since it's
not important information and made the message long.

Author: Masahiko Sawada
Reviewed-by: Takamichi Osumi, and Amit Kapila
Discussion: https://postgr.es/m/CAD21AoBarBf2oTF71ig2g_o=3Z_Dt6_sOpMQma1kFgbnA5OZ_w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5e0e99a80b2f41c8e9ed0f4071892d9e797a12be

Modified Files
--------------
src/backend/replication/logical/worker.c | 73 +++++++++++++++-----------------
1 file changed, 33 insertions(+), 40 deletions(-)



Message-ID: <E1nR423-001HH4-31@gemulon.postgresql.org>
Permalink:  ../E1nR423-001HH4-31@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nR423-001HH4-31@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org
  Subject: Re: pgsql: Make the errcontext message in logical replication worker transl
  In-Reply-To: <E1nR423-001HH4-31@gemulon.postgresql.org>
  References: <E1nR423-001HH4-31@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox