pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Stabilize test_decoding touching with sequences
Date: Tue, 08 Mar 2022 18:24:00 +0000
Message-ID: <E1nReV5-001VqX-S2@gemulon.postgresql.org> (raw)

Stabilize test_decoding touching with sequences

Some of the test_decoding regression tests are unstable due to modifying
a sequence. The first increment of a sequence after a checkpoint is
always logged (and thus decoded), which makes the output unpredictable.
The runs are usually much shorter than a checkpoint internal, so these
failures are rare, but we've seen a couple of them on animals that are
either slow or are running with valgrind/clobber cache/...

Fixed by skipping sequence decoding in most tests, with the exception of
the test aimed at testing decoding of sequences.

Reported-by: Amita Kapila
Discussion: https://postgr.es/m/d045f3c2-6cfb-06d3-5540-e63c320df8bc@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a180c2b34de0989269fdb819bff241a249bf5380

Modified Files
--------------
contrib/test_decoding/expected/ddl.out             | 26 +++++++++++-----------
.../test_decoding/expected/decoding_in_xact.out    |  2 +-
contrib/test_decoding/expected/replorigin.out      |  8 +++----
contrib/test_decoding/expected/rewrite.out         |  2 +-
contrib/test_decoding/expected/slot.out            |  6 ++---
contrib/test_decoding/sql/ddl.sql                  | 26 +++++++++++-----------
contrib/test_decoding/sql/decoding_in_xact.sql     |  2 +-
contrib/test_decoding/sql/replorigin.sql           |  8 +++----
contrib/test_decoding/sql/rewrite.sql              |  2 +-
contrib/test_decoding/sql/slot.sql                 |  6 ++---
10 files changed, 44 insertions(+), 44 deletions(-)



Message-ID: <E1nReV5-001VqX-S2@gemulon.postgresql.org>
Permalink:  ../E1nReV5-001VqX-S2@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nReV5-001VqX-S2@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org
  Subject: Re: pgsql: Stabilize test_decoding touching with sequences
  In-Reply-To: <E1nReV5-001VqX-S2@gemulon.postgresql.org>
  References: <E1nReV5-001VqX-S2@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox