pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Restore the previous semantics of get_constraint_index().
Date: Fri, 11 Mar 2022 18:47:58 +0000
Message-ID: <E1nSkIw-000Izy-3X@gemulon.postgresql.org> (raw)

Restore the previous semantics of get_constraint_index().

Commit 8b069ef5d changed this function to look at pg_constraint.conindid
rather than searching pg_depend.  That was a good performance improvement,
but it failed to preserve the exact semantics.  The old code would only
return an index that was "owned by" (internally dependent on) the
specified constraint, whereas the new code will also return indexes that
are just referenced by foreign key constraints.  This confuses ALTER
TABLE, which was implicitly expecting the previous semantics, into
failing with errors like
    ERROR:  relation 146621 has multiple clustered indexes
or
    ERROR:  "pk_attbl" is not an index for table "atref"

We can fix this without reverting the performance improvement by adding
a contype check in get_constraint_index().  Another way could be to
make ALTER TABLE check it, but I'm worried that extension code could
also have subtle dependencies on the old semantics.

Tom Lane and Japin Li, per bug #17409 from Holly Roberts.
Back-patch to v14 where the error crept in.

Discussion: https://postgr.es/m/17409-52871dda8b5741cb@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/641f3dffcdf1c7378cfb94c98b6642793181d6db

Modified Files
--------------
src/backend/utils/cache/lsyscache.c       | 16 +++++++++++++---
src/test/regress/expected/alter_table.out | 14 ++++++++++++++
src/test/regress/sql/alter_table.sql      | 18 ++++++++++++++++++
3 files changed, 45 insertions(+), 3 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1nSkIw-000Izy-3X@gemulon.postgresql.org>
Permalink:  ../E1nSkIw-000Izy-3X@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nSkIw-000Izy-3X@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Restore the previous semantics of get_constraint_index().
  In-Reply-To: <E1nSkIw-000Izy-3X@gemulon.postgresql.org>
  References: <E1nSkIw-000Izy-3X@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox