pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pageinspect: Fix memory context allocation of page in brin_revma
Date: Wed, 16 Mar 2022 03:30:42 +0000
Message-ID: <E1nUKN0-000GYL-FE@gemulon.postgresql.org> (raw)

pageinspect: Fix memory context allocation of page in brin_revmap_data()

This caused the function to fail, as the aligned copy of the raw page
given by the function caller was not saved in the correct memory
context, which needs to be multi_call_memory_ctx in this case.

Issue introduced by 076f4d9.

Per buildfarm members sifika, mylodon and longfin.  I have reproduced
that locally with macos.

Discussion: https://postgr.es/m/YjFPOtfCW6yLXUeM@paquier.xyz
Backpatch-through: 10

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/07e343513b85ea152f4cc2d3afeb2d4c87bbda77

Modified Files
--------------
contrib/pageinspect/brinfuncs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1nUKN0-000GYL-FE@gemulon.postgresql.org>
Permalink:  ../E1nUKN0-000GYL-FE@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nUKN0-000GYL-FE@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: pageinspect: Fix memory context allocation of page in brin_revma
  In-Reply-To: <E1nUKN0-000GYL-FE@gemulon.postgresql.org>
  References: <E1nUKN0-000GYL-FE@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox