pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix incorrect xmlschema output for types timetz and timestamptz.
Date: Fri, 18 Mar 2022 20:02:04 +0000
Message-ID: <E1nVInU-000JWH-55@gemulon.postgresql.org> (raw)

Fix incorrect xmlschema output for types timetz and timestamptz.

The output of table_to_xmlschema() and allied functions includes
a regex describing valid values for these types ... but the regex
was itself invalid, as it failed to escape a literal "+" sign.

Report and fix by Renan Soares Lopes.  Back-patch to all
supported branches.

Discussion: https://postgr.es/m/7f6fabaa-3f8f-49ab-89ca-59fbfe633105@me.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/88ae77588d9a891c492f8ba543b3c1064c7a8ef3

Modified Files
--------------
src/backend/utils/adt/xml.c            |   4 +-
src/test/regress/expected/xmlmap.out   | 928 ++++++++++++++++++---------------
src/test/regress/expected/xmlmap_1.out |  10 +-
src/test/regress/sql/xmlmap.sql        |  10 +-
4 files changed, 514 insertions(+), 438 deletions(-)



view thread (6+ messages)

Message-ID: <E1nVInU-000JWH-55@gemulon.postgresql.org>
Permalink:  ../E1nVInU-000JWH-55@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nVInU-000JWH-55@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix incorrect xmlschema output for types timetz and timestamptz.
  In-Reply-To: <E1nVInU-000JWH-55@gemulon.postgresql.org>
  References: <E1nVInU-000JWH-55@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox