pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_basebackup: Try to fix some failures on Windows.
Date: Wed, 23 Mar 2022 17:27:04 +0000
Message-ID: <E1nX4lD-00139D-JG@gemulon.postgresql.org> (raw)

pg_basebackup: Try to fix some failures on Windows.

Commit ffd53659c46a54a6978bcb8c4424c1e157a2c0f1 messed up the
mechanism that was being used to pass parameters to LogStreamerMain()
on Windows. It worked on Linux because only Windows was using threads.
Repair by moving the additional parameters added by that commit into
the 'logstreamer_param' struct.

Along the way, fix a compiler warning on builds without HAVE_LIBZ.

Discussion: http://postgr.es/m/CA+TgmoY5=AmWOtMj3v+cySP2rR=Bt6EGyF_joAq4CfczMddKtw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/591767150f5f91ccc3614e71977c47ce7a68786b

Modified Files
--------------
src/backend/replication/basebackup_gzip.c |  3 +--
src/bin/pg_basebackup/pg_basebackup.c     | 14 ++++++++------
2 files changed, 9 insertions(+), 8 deletions(-)



Message-ID: <E1nX4lD-00139D-JG@gemulon.postgresql.org>
Permalink:  ../E1nX4lD-00139D-JG@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nX4lD-00139D-JG@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: pg_basebackup: Try to fix some failures on Windows.
  In-Reply-To: <E1nX4lD-00139D-JG@gemulon.postgresql.org>
  References: <E1nX4lD-00139D-JG@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox