pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
7+ messages / 1 participants
[nested] [flat]

* pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
@ 2022-03-23 18:26 Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-03-23 18:28 ` Re: pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 1 reply; 7+ messages in thread

From: Alvaro Herrera @ 2022-03-23 18:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_upgrade: Upgrade an Assert to a real 'if' test

It seems possible for the condition being tested to be true in
production, and nobody would never know (except when some data
eventually becomes corrupt?).

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m//202109040001.zky3wgv2qeqg@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3e1c942a4e2f06e9b0196180eb8fd1383e6d788e

Modified Files
--------------
src/bin/pg_rewind/parsexlog.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* Re: pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
  2022-03-23 18:26 pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2022-03-23 18:28 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Alvaro Herrera @ 2022-03-23 18:28 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

On 2022-Mar-23, Alvaro Herrera wrote:

> Discussion: https://postgr.es/m//202109040001.zky3wgv2qeqg@alvherre.pgsql

Hmm, apparently the double slash here makes the link invalid.  I had
never realized that that URL-handling thingy was so brittle.  Anyway,
the correct URL of course is
https://postgr.es/m/202109040001.zky3wgv2qeqg@alvherre.pgsql

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/





^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
@ 2022-03-23 18:26 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Alvaro Herrera @ 2022-03-23 18:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_upgrade: Upgrade an Assert to a real 'if' test

It seems possible for the condition being tested to be true in
production, and nobody would never know (except when some data
eventually becomes corrupt?).

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m//202109040001.zky3wgv2qeqg@alvherre.pgsql

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9814c708c657a9f21fd1a36b5dc0f49ca2d01499

Modified Files
--------------
src/bin/pg_rewind/parsexlog.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
@ 2022-03-23 18:26 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Alvaro Herrera @ 2022-03-23 18:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_upgrade: Upgrade an Assert to a real 'if' test

It seems possible for the condition being tested to be true in
production, and nobody would never know (except when some data
eventually becomes corrupt?).

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m//202109040001.zky3wgv2qeqg@alvherre.pgsql

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ca26c64581b529b2191757dbb27b94c6b0c101be

Modified Files
--------------
src/bin/pg_rewind/parsexlog.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
@ 2022-03-23 18:26 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Alvaro Herrera @ 2022-03-23 18:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_upgrade: Upgrade an Assert to a real 'if' test

It seems possible for the condition being tested to be true in
production, and nobody would never know (except when some data
eventually becomes corrupt?).

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m//202109040001.zky3wgv2qeqg@alvherre.pgsql

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8e0c76be195e1ec732b750e702b84592293bd8d8

Modified Files
--------------
src/bin/pg_rewind/parsexlog.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
@ 2022-03-23 18:26 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Alvaro Herrera @ 2022-03-23 18:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_upgrade: Upgrade an Assert to a real 'if' test

It seems possible for the condition being tested to be true in
production, and nobody would never know (except when some data
eventually becomes corrupt?).

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m//202109040001.zky3wgv2qeqg@alvherre.pgsql

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/efe44fb2f685032ab73ec99cd39712a1ad458c3c

Modified Files
--------------
src/bin/pg_rewind/parsexlog.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
@ 2022-03-23 18:26 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Alvaro Herrera @ 2022-03-23 18:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_upgrade: Upgrade an Assert to a real 'if' test

It seems possible for the condition being tested to be true in
production, and nobody would never know (except when some data
eventually becomes corrupt?).

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m//202109040001.zky3wgv2qeqg@alvherre.pgsql

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d8718edf6017ba647abb2715d6196ca53bb3aec6

Modified Files
--------------
src/bin/pg_rewind/parsexlog.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2022-03-23 18:28 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-03-23 18:26 pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-03-23 18:28 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-03-23 18:26 pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-03-23 18:26 pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-03-23 18:26 pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-03-23 18:26 pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-03-23 18:26 pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test Alvaro Herrera <alvherre@alvh.no-ip.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox