From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
Date: Wed, 23 Mar 2022 18:26:15 +0000
Message-ID: <E1nX5gV-0013d9-2S@gemulon.postgresql.org> (raw)
pg_upgrade: Upgrade an Assert to a real 'if' test
It seems possible for the condition being tested to be true in
production, and nobody would never know (except when some data
eventually becomes corrupt?).
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m//202109040001.zky3wgv2qeqg@alvherre.pgsql
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d8718edf6017ba647abb2715d6196ca53bb3aec6
Modified Files
--------------
src/bin/pg_rewind/parsexlog.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org
Subject: Re: pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
In-Reply-To: <E1nX5gV-0013d9-2S@gemulon.postgresql.org>
References: <E1nX5gV-0013d9-2S@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox