pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Etsuro Fujita <efujita@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: postgres_fdw: Minor cleanup for pgfdw_abort_cleanup().
Date: Fri, 25 Mar 2022 06:37:03 +0000
Message-ID: <E1nXdZG-001HUq-Tz@gemulon.postgresql.org> (raw)

postgres_fdw: Minor cleanup for pgfdw_abort_cleanup().

Commit 85c696112 introduced this function to deduplicate code in the
transaction callback functions, but the SQL command passed as an
argument to it was useless when it returned before aborting a remote
transaction using the command.  Modify pgfdw_abort_cleanup() so that it
constructs the command when/if necessary, as before, removing the
argument from it.  Also update comments in pgfdw_abort_cleanup() and one
of the calling functions.

Etsuro Fujita, reviewed by David Zhang.

Discussion: https://postgr.es/m/CAPmGK158hrd%3DZfXmgkmNFHivgh18e4oE2Gz151C2Q4OBDjZ08A%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/56566835039ac5eed70f188518cef1a7ea0971b2

Modified Files
--------------
contrib/postgres_fdw/connection.c | 29 +++++++++++++++--------------
1 file changed, 15 insertions(+), 14 deletions(-)



Message-ID: <E1nXdZG-001HUq-Tz@gemulon.postgresql.org>
Permalink:  ../E1nXdZG-001HUq-Tz@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nXdZG-001HUq-Tz@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: efujita@postgresql.org
  Subject: Re: pgsql: postgres_fdw: Minor cleanup for pgfdw_abort_cleanup().
  In-Reply-To: <E1nXdZG-001HUq-Tz@gemulon.postgresql.org>
  References: <E1nXdZG-001HUq-Tz@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox