pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor DLSUFFIX handling
Date: Fri, 25 Mar 2022 08:01:50 +0000
Message-ID: <E1nXetJ-001I8t-Gm@gemulon.postgresql.org> (raw)

Refactor DLSUFFIX handling

Move DLSUFFIX from makefiles into header files for all platforms.
Move the DLSUFFIX assignment from src/makefiles/ to src/templates/,
have configure read it, and then substitute it into Makefile.global
and pg_config.h.  This avoids the need for all makefile rules that
need it to locally set CPPFLAGS.  It also resolves an inconsistent
setup between the two Windows build systems.

Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/2f9861fb-8969-9005-7518-b8e60f2bead9@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/23119d51a14c046dae35ae5e6ad9e35982d044fd

Modified Files
--------------
config/python.m4                  |  4 +++-
configure                         | 14 +++++++++++++-
configure.ac                      |  7 +++++++
src/Makefile.global.in            |  2 ++
src/backend/jit/Makefile          |  2 --
src/backend/utils/fmgr/Makefile   |  2 --
src/backend/utils/fmgr/dfmgr.c    |  5 -----
src/bin/pg_upgrade/Makefile       |  2 +-
src/include/pg_config.h.in        |  3 +++
src/include/port/win32_port.h     |  3 ---
src/interfaces/ecpg/test/Makefile |  1 -
src/makefiles/Makefile.aix        |  1 -
src/makefiles/Makefile.cygwin     |  1 -
src/makefiles/Makefile.darwin     |  2 --
src/makefiles/Makefile.freebsd    |  2 --
src/makefiles/Makefile.hpux       |  6 ------
src/makefiles/Makefile.linux      |  2 --
src/makefiles/Makefile.netbsd     |  2 --
src/makefiles/Makefile.openbsd    |  2 --
src/makefiles/Makefile.solaris    |  2 --
src/makefiles/Makefile.win32      |  1 -
src/template/cygwin               |  2 ++
src/template/hpux                 |  7 +++++++
src/template/win32                |  2 ++
src/test/regress/GNUmakefile      |  3 +--
src/tools/msvc/Solution.pm        |  1 +
26 files changed, 42 insertions(+), 39 deletions(-)



Message-ID: <E1nXetJ-001I8t-Gm@gemulon.postgresql.org>
Permalink:  ../E1nXetJ-001I8t-Gm@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nXetJ-001I8t-Gm@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Refactor DLSUFFIX handling
  In-Reply-To: <E1nXetJ-001I8t-Gm@gemulon.postgresql.org>
  References: <E1nXetJ-001I8t-Gm@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox