From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Handle sequences in preprocess_pubobj_list
Date: Fri, 25 Mar 2022 13:37:53 +0000
Message-ID: <E1nXk8W-001KKc-Ep@gemulon.postgresql.org> (raw)
Handle sequences in preprocess_pubobj_list
Commit 75b1521dae added support for logical replication of sequences,
including grammar changes, but it did not update preprocess_pubobj_list
accordingly. This can cause segfaults with "continuations", i.e. when
command specifies a list of objects:
CREATE PUBLICATION p FOR SEQUENCE s1, s2;
Reported by Amit Kapila, patch by me.
Reported-by: Amit Kapila
Discussion: https://postgr.es/m/CAA4eK1JxDNKGBSNTyN-Xj2JRjzFo+ziSqJbjH==vuO0YF_CQrg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/002c9dd97a0c874fd1693a570383e2dd38cd40d5
Modified Files
--------------
src/backend/parser/gram.y | 27 ++++++++++++++++++++++++++-
src/test/regress/expected/publication.out | 18 ++++++++++++++++++
src/test/regress/sql/publication.sql | 16 ++++++++++++++++
3 files changed, 60 insertions(+), 1 deletion(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tomas.vondra@postgresql.org
Subject: Re: pgsql: Handle sequences in preprocess_pubobj_list
In-Reply-To: <E1nXk8W-001KKc-Ep@gemulon.postgresql.org>
References: <E1nXk8W-001KKc-Ep@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox