pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Harden TAP tests that intentionally corrupt page checksums.
Date: Fri, 25 Mar 2022 18:23:54 +0000
Message-ID: <E1nXobJ-001M7k-F1@gemulon.postgresql.org> (raw)

Harden TAP tests that intentionally corrupt page checksums.

The previous method for doing that was to write zeroes into a
predetermined set of page locations.  However, there's a roughly
1-in-64K chance that the existing checksum will match by chance,
and yesterday several buildfarm animals started to reproducibly
see that, resulting in test failures because no checksum mismatch
was reported.

Since the checksum includes the page LSN, test success depends on
the length of the installation's WAL history, which is affected by
(at least) the initial catalog contents, the set of locales installed
on the system, and the length of the pathname of the test directory.
Sooner or later we were going to hit a chance match, and today is
that day.

Harden these tests by specifically inverting the checksum field and
leaving all else alone, thereby guaranteeing that the checksum is
incorrect.

In passing, fix places that were using seek() to set up for syswrite(),
a combination that the Perl docs very explicitly warn against.  We've
probably escaped problems because no regular buffered I/O is done on
these filehandles; but if it ever breaks, we wouldn't deserve or get
much sympathy.

Although we've only seen problems in HEAD, now that we recognize the
environmental dependencies it seems like it might be just a matter
of time until someone manages to hit this in back-branch testing.
Hence, back-patch to v11 where we started doing this kind of test.

Discussion: https://postgr.es/m/3192026.1648185780@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/174877f1e344812f620fd8891af97104d5dfca13

Modified Files
--------------
contrib/amcheck/t/001_verify_heapam.pl       |  5 ++--
src/bin/pg_amcheck/t/003_check.pl            |  5 ++--
src/bin/pg_amcheck/t/004_verify_heapam.pl    |  9 ++++----
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 34 +++++++++-------------------
src/bin/pg_checksums/t/002_actions.pl        | 10 ++------
src/test/perl/PostgreSQL/Test/Cluster.pm     | 31 +++++++++++++++++++++++++
6 files changed, 52 insertions(+), 42 deletions(-)



view thread (5+ messages)

Message-ID: <E1nXobJ-001M7k-F1@gemulon.postgresql.org>
Permalink:  ../E1nXobJ-001M7k-F1@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nXobJ-001M7k-F1@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Harden TAP tests that intentionally corrupt page checksums.
  In-Reply-To: <E1nXobJ-001M7k-F1@gemulon.postgresql.org>
  References: <E1nXobJ-001M7k-F1@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox