pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix breakage of get_ps_display() in the PS_USE_NONE case. 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix breakage of get_ps_display() in the PS_USE_NONE case. @ 2022-03-27 16:58 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2022-03-27 16:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix breakage of get_ps_display() in the PS_USE_NONE case. Commit 8c6d30f21 caused this function to fail to set *displen in the PS_USE_NONE code path. If the variable's previous value had been negative, that'd lead to a memory clobber at some call sites. We'd managed not to notice due to very thin test coverage of such configurations, but this appears to explain buildfarm member lorikeet's recent struggles. Credit to Andrew Dunstan for spotting the problem. Back-patch to v13 where the bug was introduced. Discussion: https://postgr.es/m/136102.1648320427@sss.pgh.pa.us Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3f7a59c59b4873a3b39838401d590f9d030a3500 Modified Files -------------- src/backend/utils/misc/ps_status.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix breakage of get_ps_display() in the PS_USE_NONE case. @ 2022-03-27 16:58 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2022-03-27 16:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix breakage of get_ps_display() in the PS_USE_NONE case. Commit 8c6d30f21 caused this function to fail to set *displen in the PS_USE_NONE code path. If the variable's previous value had been negative, that'd lead to a memory clobber at some call sites. We'd managed not to notice due to very thin test coverage of such configurations, but this appears to explain buildfarm member lorikeet's recent struggles. Credit to Andrew Dunstan for spotting the problem. Back-patch to v13 where the bug was introduced. Discussion: https://postgr.es/m/136102.1648320427@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0fb6954aa5012fc0c41af364fb328f90e648f6b7 Modified Files -------------- src/backend/utils/misc/ps_status.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix breakage of get_ps_display() in the PS_USE_NONE case. @ 2022-03-27 16:58 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2022-03-27 16:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix breakage of get_ps_display() in the PS_USE_NONE case. Commit 8c6d30f21 caused this function to fail to set *displen in the PS_USE_NONE code path. If the variable's previous value had been negative, that'd lead to a memory clobber at some call sites. We'd managed not to notice due to very thin test coverage of such configurations, but this appears to explain buildfarm member lorikeet's recent struggles. Credit to Andrew Dunstan for spotting the problem. Back-patch to v13 where the bug was introduced. Discussion: https://postgr.es/m/136102.1648320427@sss.pgh.pa.us Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9016a2a3dc4ee7e41ecda5a8b3a3d3481de94964 Modified Files -------------- src/backend/utils/misc/ps_status.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2022-03-27 16:58 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-03-27 16:58 pgsql: Fix breakage of get_ps_display() in the PS_USE_NONE case. Tom Lane <tgl@sss.pgh.pa.us> 2022-03-27 16:58 pgsql: Fix breakage of get_ps_display() in the PS_USE_NONE case. Tom Lane <tgl@sss.pgh.pa.us> 2022-03-27 16:58 pgsql: Fix breakage of get_ps_display() in the PS_USE_NONE case. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox