pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix breakage of get_ps_display() in the PS_USE_NONE case.
Date: Sun, 27 Mar 2022 16:58:21 +0000
Message-ID: <E1nYWDd-001dPv-8C@gemulon.postgresql.org> (raw)

Fix breakage of get_ps_display() in the PS_USE_NONE case.

Commit 8c6d30f21 caused this function to fail to set *displen
in the PS_USE_NONE code path.  If the variable's previous value
had been negative, that'd lead to a memory clobber at some call
sites.  We'd managed not to notice due to very thin test coverage
of such configurations, but this appears to explain buildfarm member
lorikeet's recent struggles.

Credit to Andrew Dunstan for spotting the problem.  Back-patch
to v13 where the bug was introduced.

Discussion: https://postgr.es/m/136102.1648320427@sss.pgh.pa.us

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3f7a59c59b4873a3b39838401d590f9d030a3500

Modified Files
--------------
src/backend/utils/misc/ps_status.c | 1 +
1 file changed, 1 insertion(+)



view thread (3+ messages)  latest in thread

Message-ID: <E1nYWDd-001dPv-8C@gemulon.postgresql.org>
Permalink:  ../E1nYWDd-001dPv-8C@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nYWDd-001dPv-8C@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix breakage of get_ps_display() in the PS_USE_NONE case.
  In-Reply-To: <E1nYWDd-001dPv-8C@gemulon.postgresql.org>
  References: <E1nYWDd-001dPv-8C@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox