From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid using large pass-by-value struct arguments in pgbench.
Date: Sun, 27 Mar 2022 18:38:40 +0000
Message-ID: <E1nYXmh-001dyM-HE@gemulon.postgresql.org> (raw)
Avoid using large pass-by-value struct arguments in pgbench.
In the wake of commit 4a39f87ac, which noticeably increased the
size of struct StatsData and thereby ParsedScript, Coverity started
to complain that ParsedScript was unreasonably large to be passing
by value. The two places that do this are only used during setup,
so they're not really dragging down benchmark measurements --- but
gratuitous inefficiency is not a good look in a benchmarking program.
Convert to use pointers instead.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/641a9b716789628a4e7403ecef1b82cc4a9552b0
Modified Files
--------------
src/bin/pgbench/pgbench.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Avoid using large pass-by-value struct arguments in pgbench.
In-Reply-To: <E1nYXmh-001dyM-HE@gemulon.postgresql.org>
References: <E1nYXmh-001dyM-HE@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox