pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix NULL input behaviour of pg_stat_get_replication_slot().
Date: Mon, 28 Mar 2022 04:53:23 +0000
Message-ID: <E1nYhNa-001hq4-Ow@gemulon.postgresql.org> (raw)

Fix NULL input behaviour of pg_stat_get_replication_slot().

pg_stat_get_replication_slot() accidentally was marked as non-strict, crashing
when called with NULL input. As it's already released, introduce an explicit
NULL check in 14, fix the catalog in HEAD.

Bumps catversion in HEAD.

Discussion: https://postgr.es/m/20220326212432.s5n2maw6kugnpyxw@alap3.anarazel.de
Backpatch: 14-, where replication slot stats were introduced

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c1a0d7d1c4b77d978fe93edc0889589148cbad23

Modified Files
--------------
src/backend/utils/adt/pgstatfuncs.c | 11 ++++++++++-
src/test/regress/expected/stats.out |  7 +++++++
src/test/regress/sql/stats.sql      |  6 ++++++
3 files changed, 23 insertions(+), 1 deletion(-)



view thread (2+ messages)

Message-ID: <E1nYhNa-001hq4-Ow@gemulon.postgresql.org>
Permalink:  ../E1nYhNa-001hq4-Ow@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nYhNa-001hq4-Ow@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: Fix NULL input behaviour of pg_stat_get_replication_slot().
  In-Reply-To: <E1nYhNa-001hq4-Ow@gemulon.postgresql.org>
  References: <E1nYhNa-001hq4-Ow@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox