From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't fail for > 1 walsenders in 019_replslot_limit, add debug m
Date: Mon, 28 Mar 2022 05:37:01 +0000
Message-ID: <E1nYi3o-001i63-NA@gemulon.postgresql.org> (raw)
Don't fail for > 1 walsenders in 019_replslot_limit, add debug messages.
So far the first of the retries introduced in f28bf667f60 resolves the
issue. But I (Andres) am still suspicious that the start of the failures might
indicate a problem.
To reduce noise, stop reporting a failure if a retry resolves the problem. To
allow figuring out what causes the slow slot drop, add a few more debug
messages to ReplicationSlotDropPtr.
See also commit afdeff10526, fe0972ee5e6 and f28bf667f60.
Discussion: https://postgr.es/m/20220327213219.smdvfkq2fl74flow@alap3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/91c0570a791180aa3ff01d70eb16ed6c0d8283a3
Modified Files
--------------
src/backend/replication/slot.c | 9 +++++++++
src/test/recovery/t/019_replslot_limit.pl | 10 +++++++---
2 files changed, 16 insertions(+), 3 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de
Subject: Re: pgsql: Don't fail for > 1 walsenders in 019_replslot_limit, add debug m
In-Reply-To: <E1nYi3o-001i63-NA@gemulon.postgresql.org>
References: <E1nYi3o-001i63-NA@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox