pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Modify query on pg_hba_file_rules to check for errors in regress
Date: Tue, 29 Mar 2022 00:09:22 +0000
Message-ID: <E1nYzQH-001pFQ-ST@gemulon.postgresql.org> (raw)

Modify query on pg_hba_file_rules to check for errors in regression tests

The regression tests include a query to check the execution path of
pg_hba_file_rules, but it has never checked that a given cluster has
correct contents in pg_hba.conf.  This commit extends the query of
pg_hba_file_rules to report any errors if anything bad is found.  For
EXEC_BACKEND builds, any connection attempt would fail when loading
pg_hba.conf if any incorrect content is found when parsed, so a failure
would be detected before even running this query.  However, this can
become handy for clusters where pg_hba.conf can be reloaded, where new
connection attempts are not subject to a fresh loading of pg_hba.conf.

Author: Julien Rouhaud, based on an idea from me
Discussion: https://postgr.es/m/YkFhpydhyeNNo3Xl@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/091a971bb59ca9751f32a4aa5aee969c5a915754

Modified Files
--------------
src/test/regress/expected/sysviews.out | 11 ++++++-----
src/test/regress/sql/sysviews.sql      |  5 +++--
2 files changed, 9 insertions(+), 7 deletions(-)



Message-ID: <E1nYzQH-001pFQ-ST@gemulon.postgresql.org>
Permalink:  ../E1nYzQH-001pFQ-ST@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nYzQH-001pFQ-ST@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Modify query on pg_hba_file_rules to check for errors in regress
  In-Reply-To: <E1nYzQH-001pFQ-ST@gemulon.postgresql.org>
  References: <E1nYzQH-001pFQ-ST@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox