pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid instabilities with the regression tests of pg_freespacemap
Date: Tue, 29 Mar 2022 04:53:14 +0000
Message-ID: <E1nZ3qz-001r5t-Ac@gemulon.postgresql.org> (raw)

Avoid instabilities with the regression tests of pg_freespacemap

It was possible to run those tests with installcheck, but they are
actually unstable as concurrent autovacuum jobs could prevent the
truncation of the filespace map to happen (aka the scan of pg_database
when building the list of relations to clean), an assumption we rely on
when checking that the FSM of the relation gets truncated during a
manual vacuum after deleting all the relation's data.

This commit adds a NO_INSTALLCHECK to disallow installcheck, and
introduces the use of a custom configuration file with autovacuum
disabled.

It happens that we already do that in the recovery test
008_fsm_truncation, for example.

Reported-by: Tom Lane, via buildfarm member skink
Discussion: https://postgr.es/m/381910.1648401526@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c14a9eeec4797358922f8696d76716501b86c57d

Modified Files
--------------
contrib/pg_freespacemap/Makefile             | 5 +++++
contrib/pg_freespacemap/pg_freespacemap.conf | 1 +
2 files changed, 6 insertions(+)



Message-ID: <E1nZ3qz-001r5t-Ac@gemulon.postgresql.org>
Permalink:  ../E1nZ3qz-001r5t-Ac@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nZ3qz-001r5t-Ac@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Avoid instabilities with the regression tests of pg_freespacemap
  In-Reply-To: <E1nZ3qz-001r5t-Ac@gemulon.postgresql.org>
  References: <E1nZ3qz-001r5t-Ac@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox