pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve handling and logging of TAP tests for pg_upgrade
Date: Fri, 01 Apr 2022 03:47:31 +0000
Message-ID: <E1na8G2-000FU1-ME@gemulon.postgresql.org> (raw)

Improve handling and logging of TAP tests for pg_upgrade

This commit includes a set of improvements to help with the debugging of
failures in these new TAP tests:
- Instead of a plain diff command to compare the dumps generated, use
File::Compare::compare for the same effect.  diff is still used to
provide more context in the event of an error.
- Log the contents of regression.diffs if the pg_regress command fails.
- Unify the format of the logs generated, getting inspiration from the
style used in 027_stream_regress.pl.

wrasse is the only buildfarm member that has reported a failure until
now after the introduction of 322becb, complaining that the dumps
generated do not match, and I am lacking information to understand what
is going in this environment.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/73db8f4d17ed4efb7709f1cafd5b1dd0285b0842

Modified Files
--------------
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 40 ++++++++++++++++++++++++++--------
1 file changed, 31 insertions(+), 9 deletions(-)



Message-ID: <E1na8G2-000FU1-ME@gemulon.postgresql.org>
Permalink:  ../E1na8G2-000FU1-ME@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1na8G2-000FU1-ME@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Improve handling and logging of TAP tests for pg_upgrade
  In-Reply-To: <E1na8G2-000FU1-ME@gemulon.postgresql.org>
  References: <E1na8G2-000FU1-ME@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox