pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make upgradecheck a no-op in MSVC's vcregress.pl
Date: Sat, 02 Apr 2022 03:07:02 +0000
Message-ID: <E1naU6P-000OSi-Ra@gemulon.postgresql.org> (raw)

Make upgradecheck a no-op in MSVC's vcregress.pl

322becb has changed upgradecheck to use the TAP tests, discarding
pg_upgrade's tests in bincheck.  However, this is proving to be a bad
idea for the Windows buildfarm clients that use MSVC when TAP tests are
disabled as this causes a hard failure at the pg_upgrade step.

This commit disables upgradecheck, moving the execution of the tests of
pg_upgrade to bincheck, as per an initial suggestion from Andres
Freund, so as the buildfarm is able to live happily with those changes.

While on it, remove the routine that was used by upgradecheck to
create databases whose names are generated with a range of ASCII
characters as it is not used since 322becb.  upgradecheck is removed
from the CI script for Windows, as bincheck takes care of that now.

Per report from buildfarm member hamerkop (MSVC 2017 without a TAP
setup).

Reviewed-by: Justin Pryzby
Discussion: https://postgr.es/m/YkbnpriYEAagZ2wH@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d2a2ce4184b0038adb1d6d292f12685056e2ab7a

Modified Files
--------------
.cirrus.yml                       |  2 --
doc/src/sgml/install-windows.sgml |  1 -
src/tools/msvc/vcregress.pl       | 33 +++++----------------------------
3 files changed, 5 insertions(+), 31 deletions(-)



Message-ID: <E1naU6P-000OSi-Ra@gemulon.postgresql.org>
Permalink:  ../E1naU6P-000OSi-Ra@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1naU6P-000OSi-Ra@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Make upgradecheck a no-op in MSVC's vcregress.pl
  In-Reply-To: <E1naU6P-000OSi-Ra@gemulon.postgresql.org>
  References: <E1naU6P-000OSi-Ra@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox