pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: dshash: revise sequential scan support.
Date: Mon, 04 Apr 2022 21:33:55 +0000
Message-ID: <E1nbUKg-000Kyv-Lu@gemulon.postgresql.org> (raw)

dshash: revise sequential scan support.

The previous coding of dshash_seq_next(), on the first call, accessed
status->hash_table->size_log2 without holding a partition lock and without
guaranteeing that ensure_valid_bucket_pointers() had ever been called.

That oversight turns out to not have immediately visible effects, because
bucket 0 is always in partition 0, and ensure_valid_bucket_pointers() was
called after acquiring the partition lock.  However,
PARTITION_FOR_BUCKET_INDEX() with a size_log2 of 0 ends up triggering formally
undefined behaviour.

Simplify by accessing partition 0, without using PARTITION_FOR_BUCKET_INDEX().

While at it, remove dshash_get_current(), there is no convincing use
case. Also polish a few comments.

Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/CA+hUKGL9hY_VY=+oUK+Gc1iSRx-Ls5qeYJ6q=dQVZnT3R63Taw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/909eebf27b9e6aaa78fb3338f7d8fbc7fa174247

Modified Files
--------------
src/backend/lib/dshash.c | 56 +++++++++++++++++++++++-------------------------
src/include/lib/dshash.h |  1 -
2 files changed, 27 insertions(+), 30 deletions(-)



Message-ID: <E1nbUKg-000Kyv-Lu@gemulon.postgresql.org>
Permalink:  ../E1nbUKg-000Kyv-Lu@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nbUKg-000Kyv-Lu@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: dshash: revise sequential scan support.
  In-Reply-To: <E1nbUKg-000Kyv-Lu@gemulon.postgresql.org>
  References: <E1nbUKg-000Kyv-Lu@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox