pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Stephen Frost <sfrost@snowman.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove exclusive backup mode
Date: Wed, 06 Apr 2022 18:43:56 +0000
Message-ID: <E1ncAdH-000cIM-Fj@gemulon.postgresql.org> (raw)

Remove exclusive backup mode

Exclusive-mode backups have been deprecated since 9.6 (when
non-exclusive backups were introduced) due to the issues
they can cause should the system crash while one is running and
generally because non-exclusive provides a much better interface.
Further, exclusive backup mode wasn't really being tested (nor was most
of the related code- like being able to log in just to stop an exclusive
backup and the bits of the state machine related to that) and having to
possibly deal with an exclusive backup and the backup_label file
existing during pg_basebackup, pg_rewind, etc, added other complexities
that we are better off without.

This patch removes the exclusive backup mode, the various special cases
for dealing with it, and greatly simplifies the online backup code and
documentation.

Authors: David Steele, Nathan Bossart
Reviewed-by: Chapman Flack
Discussion: https://postgr.es/m/ac7339ca-3718-3c93-929f-99e725d1172c@pgmasters.net
https://postgr.es/m/CAHg+QDfiM+WU61tF6=nPZocMZvHDzCK47Kneyb0ZRULYzV5sKQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/39969e2a1e4d7f5a37f3ef37d53bbfe171e7d77a

Modified Files
--------------
doc/src/sgml/backup.sgml                           | 241 ++--------
doc/src/sgml/func.sgml                             | 111 +----
doc/src/sgml/high-availability.sgml                |   6 +-
doc/src/sgml/monitoring.sgml                       |   4 +-
doc/src/sgml/ref/pg_ctl-ref.sgml                   |   6 +-
doc/src/sgml/ref/pgupgrade.sgml                    |   2 +-
doc/src/sgml/runtime.sgml                          |   8 +-
src/backend/access/transam/xlog.c                  | 519 +++------------------
src/backend/access/transam/xlogfuncs.c             | 253 ++--------
src/backend/access/transam/xlogrecovery.c          |  20 +-
src/backend/catalog/system_functions.sql           |  18 +-
src/backend/postmaster/postmaster.c                |  75 +--
src/backend/replication/basebackup.c               |  20 +-
src/backend/utils/init/postinit.c                  |  18 -
src/bin/pg_basebackup/t/010_pg_basebackup.pl       |   4 +
src/bin/pg_ctl/pg_ctl.c                            |  30 --
src/bin/pg_rewind/filemap.c                        |   6 +-
src/include/access/xlog.h                          |   7 +-
src/include/catalog/pg_control.h                   |   4 +-
src/include/catalog/pg_proc.dat                    |  28 +-
src/include/libpq/libpq-be.h                       |   3 +-
src/include/miscadmin.h                            |   4 -
src/test/perl/PostgreSQL/Test/Cluster.pm           |  56 +--
.../recovery/t/010_logical_decoding_timelines.pl   |   4 +-
24 files changed, 247 insertions(+), 1200 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1ncAdH-000cIM-Fj@gemulon.postgresql.org>
Permalink:  ../E1ncAdH-000cIM-Fj@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ncAdH-000cIM-Fj@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: sfrost@snowman.net
  Subject: Re: pgsql: Remove exclusive backup mode
  In-Reply-To: <E1ncAdH-000cIM-Fj@gemulon.postgresql.org>
  References: <E1ncAdH-000cIM-Fj@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox