pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feed From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgstat: stats collector references in comments.
Date: Wed, 06 Apr 2022 20:57:57 +0000
Message-ID: <E1ncCiz-000dFF-8O@gemulon.postgresql.org> (raw )
pgstat: stats collector references in comments.
Soon the stats collector will be no more, with statistics instead getting
stored in shared memory. There are a lot of references to the stats collector
in comments. This commit replaces most of these references with "cumulative
statistics system", with the remaining ones getting replaced as part of
subsequent commits.
This is done separately from the - quite large - shared memory statistics
patch to make review easier.
Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Justin Pryzby <pryzby@telsasoft.com>
Reviewed-By: Thomas Munro <thomas.munro@gmail.com>
Reviewed-By: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220303021600.hs34ghqcw6zcokdh@alap3.anarazel.de
Discussion: https://postgr.es/m/20220308205351.2xcn6k4x5yivcxyd@alap3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bdbd3d9064f9dbd064253e05f156ec77d4a90d05
Modified Files
--------------
contrib/test_decoding/t/001_repl_stats.pl | 3 +--
src/backend/access/heap/heapam_handler.c | 4 ++--
src/backend/access/heap/vacuumlazy.c | 8 +++----
src/backend/commands/analyze.c | 2 +-
src/backend/commands/dbcommands.c | 2 +-
src/backend/commands/matview.c | 8 +++----
src/backend/commands/subscriptioncmds.c | 4 ++--
src/backend/commands/vacuum.c | 4 ++--
src/backend/postmaster/autovacuum.c | 14 ++++++------
src/backend/postmaster/bgwriter.c | 4 +---
src/backend/postmaster/checkpointer.c | 14 ++++--------
src/backend/postmaster/pgarch.c | 8 +++----
src/backend/postmaster/pgstat.c | 28 ++++++++++++------------
src/backend/postmaster/walwriter.c | 9 ++++----
src/backend/replication/basebackup.c | 4 ++--
src/backend/tcop/postgres.c | 8 +++----
src/backend/utils/activity/pgstat_archiver.c | 3 +--
src/backend/utils/activity/pgstat_bgwriter.c | 2 +-
src/backend/utils/activity/pgstat_checkpointer.c | 2 +-
src/backend/utils/activity/pgstat_database.c | 14 ++++++------
src/backend/utils/activity/pgstat_relation.c | 16 +++++++-------
src/backend/utils/activity/pgstat_replslot.c | 10 ++++-----
src/backend/utils/activity/pgstat_slru.c | 3 +--
src/backend/utils/activity/pgstat_subscription.c | 8 +++----
src/backend/utils/adt/pgstatfuncs.c | 4 ++--
src/backend/utils/error/elog.c | 2 +-
src/include/pgstat.h | 4 ++--
src/include/utils/backend_status.h | 4 ++--
src/include/utils/pgstat_internal.h | 2 +-
src/test/regress/expected/stats.out | 2 +-
src/test/regress/sql/stats.sql | 2 +-
31 files changed, 95 insertions(+), 107 deletions(-)
Message-ID: <E1ncCiz-000dFF-8O@gemulon.postgresql.org>
Permalink: ../E1ncCiz-000dFF-8O@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1ncCiz-000dFF-8O@gemulon.postgresql.org
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de
Subject: Re: pgsql: pgstat: stats collector references in comments.
In-Reply-To: <E1ncCiz-000dFF-8O@gemulon.postgresql.org>
References: <E1ncCiz-000dFF-8O@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox