pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgstat: remove stats_temp_directory.
Date: Thu, 07 Apr 2022 04:37:02 +0000
Message-ID: <E1ncJtG-000gDN-1l@gemulon.postgresql.org> (raw)

pgstat: remove stats_temp_directory.

With stats now being stored in shared memory, the GUC isn't needed
anymore. However, the pg_stat_tmp directory and PG_STAT_TMP_DIR define are
kept, as pg_stat_statements (and some out-of-core extensions) store data in
it.

Docs will be updated in a subsequent commit, together with the other pending
docs updates due to shared memory stats.

Author: Andres Freund <andres@anarazel.de>
Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-By: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220330233550.eiwsbearu6xhuqwe@alap3.anarazel.de
Discussion: https://postgr.es/m/20220303021600.hs34ghqcw6zcokdh@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6f0cf87872ab2fd4a81249ca9d6299b9b1a52277

Modified Files
--------------
contrib/pg_stat_statements/pg_stat_statements.c |  7 +----
src/backend/postmaster/pgstat.c                 | 10 ------
src/backend/replication/basebackup.c            | 36 ++--------------------
src/backend/utils/misc/guc.c                    | 41 -------------------------
src/backend/utils/misc/postgresql.conf.sample   |  1 -
src/bin/pg_rewind/filemap.c                     |  5 ++-
src/include/pgstat.h                            |  4 ---
src/test/perl/PostgreSQL/Test/Cluster.pm        |  4 ---
8 files changed, 5 insertions(+), 103 deletions(-)



Message-ID: <E1ncJtG-000gDN-1l@gemulon.postgresql.org>
Permalink:  ../E1ncJtG-000gDN-1l@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ncJtG-000gDN-1l@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: pgstat: remove stats_temp_directory.
  In-Reply-To: <E1ncJtG-000gDN-1l@gemulon.postgresql.org>
  References: <E1ncJtG-000gDN-1l@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox