From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgstat: prevent fix pgstat_reinit_entry() from zeroing out lwloc
Date: Thu, 07 Apr 2022 06:39:53 +0000
Message-ID: <E1ncLo9-000hD6-1N@gemulon.postgresql.org> (raw)
pgstat: prevent fix pgstat_reinit_entry() from zeroing out lwlock.
Zeroing out an lwlock in a normal build turns out to not trigger any alarms,
if nobody can use the lwlock at that moment (as the case here). But with
--disable-spinlocks --disable-atomics, the sema field needs to be initialized.
We probably should make sure that this fails on more common configurations as
well...
Per buildfarm animal rorqual
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/81ae9e65887476b4c55aaad276a8010a459a41ce
Modified Files
--------------
src/backend/utils/activity/pgstat_shmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de
Subject: Re: pgsql: pgstat: prevent fix pgstat_reinit_entry() from zeroing out lwloc
In-Reply-To: <E1ncLo9-000hD6-1N@gemulon.postgresql.org>
References: <E1ncLo9-000hD6-1N@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox