pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Explicitly ignore guaranteed-true result from pgstat_lock_entry(
Date: Mon, 11 Apr 2022 17:22:40 +0000
Message-ID: <E1ndxkO-0003JH-9r@gemulon.postgresql.org> (raw)

Explicitly ignore guaranteed-true result from pgstat_lock_entry().

With nowait passed as false, pgstat_lock_entry() must return true
so there's no need to check its result.  Coverity seems unconvinced
of this, so whack it upside the head with a (void) cast.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3c702b3ed1519624d50e7a42283b8d481a579f77

Modified Files
--------------
src/backend/utils/activity/pgstat_shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Message-ID: <E1ndxkO-0003JH-9r@gemulon.postgresql.org>
Permalink:  ../E1ndxkO-0003JH-9r@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ndxkO-0003JH-9r@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Explicitly ignore guaranteed-true result from pgstat_lock_entry(
  In-Reply-To: <E1ndxkO-0003JH-9r@gemulon.postgresql.org>
  References: <E1ndxkO-0003JH-9r@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox