From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove dead code in do_pg_backup_start().
Date: Mon, 11 Apr 2022 19:56:14 +0000
Message-ID: <E1ne090-0004Ts-MP@gemulon.postgresql.org> (raw)
Remove dead code in do_pg_backup_start().
As of commit 39969e2a1, no caller of do_pg_backup_start() passes NULL
for labelfile or tblspcmapfile, nor is it plausible that any would
do so in the future. Remove the code that coped with that case,
as (a) it's dead and (b) it causes Coverity to bleat about possibly
leaked storage.
While here, do some janitorial work on the function's header comment.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9de692c10176e2af00dc915b122e07bd6903185c
Modified Files
--------------
src/backend/access/transam/xlog.c | 30 +++++++++++++-----------------
1 file changed, 13 insertions(+), 17 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Remove dead code in do_pg_backup_start().
In-Reply-To: <E1ne090-0004Ts-MP@gemulon.postgresql.org>
References: <E1ne090-0004Ts-MP@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox