From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rename backup_compression.{c,h} to compression.{c,h}
Date: Tue, 12 Apr 2022 04:39:23 +0000
Message-ID: <E1ne8JH-0007gv-F8@gemulon.postgresql.org> (raw)
Rename backup_compression.{c,h} to compression.{c,h}
Compression option handling (level, algorithm or even workers) can be
used across several parts of the system and not only base backups.
Structures, objects and routines are renamed in consequence, to remove
the concept of base backups from this part of the code making this
change straight-forward.
pg_receivewal, that has gained support for LZ4 since babbbb5, will make
use of this infrastructure for its set of compression options, bringing
more consistency with pg_basebackup. This cleanup needs to be done
before releasing a beta of 15. pg_dump is a potential future target, as
well, and adding more compression options to it may happen in 16~.
Author: Michael Paquier
Reviewed-by: Robert Haas, Georgios Kokolatos
Discussion: https://postgr.es/m/YlPQGNAAa04raObK@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a4b57543acfb52cc7c7e031501002563f536b929
Modified Files
--------------
src/backend/replication/basebackup.c | 24 ++++----
src/backend/replication/basebackup_gzip.c | 4 +-
src/backend/replication/basebackup_lz4.c | 4 +-
src/backend/replication/basebackup_zstd.c | 10 ++--
src/bin/pg_basebackup/bbstreamer.h | 8 +--
src/bin/pg_basebackup/bbstreamer_gzip.c | 4 +-
src/bin/pg_basebackup/bbstreamer_lz4.c | 4 +-
src/bin/pg_basebackup/bbstreamer_zstd.c | 6 +-
src/bin/pg_basebackup/nls.mk | 2 +-
src/bin/pg_basebackup/pg_basebackup.c | 44 +++++++--------
src/common/Makefile | 2 +-
src/common/{backup_compression.c => compression.c} | 66 +++++++++++-----------
src/include/common/backup_compression.h | 46 ---------------
src/include/common/compression.h | 46 +++++++++++++++
src/include/replication/basebackup_sink.h | 8 +--
src/tools/msvc/Mkvcbuild.pm | 2 +-
src/tools/pgindent/typedefs.list | 2 +
17 files changed, 142 insertions(+), 140 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz
Subject: Re: pgsql: Rename backup_compression.{c,h} to compression.{c,h}
In-Reply-To: <E1ne8JH-0007gv-F8@gemulon.postgresql.org>
References: <E1ne8JH-0007gv-F8@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox