pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove WalCompressionMethod in favor of pg_compress_algorithm
Date: Tue, 12 Apr 2022 08:35:08 +0000
Message-ID: <E1neBzQ-0009EK-Ib@gemulon.postgresql.org> (raw)

Remove WalCompressionMethod in favor of pg_compress_algorithm

The same structure, with the same set of elements (for none, lz4, gzip
and zstd), exists in compression.h, so let's make use of the centralized
version instead of duplicating things.  Some of the variables used
previously for WalCompressionMethod are renamed to stick better with the
new structure and routine names.

WalCompressionMethod was leading to some confusion in walmethods.c, as
it was sometimes used to refer to some data unrelated to WAL.

Reported-by: Robert Haas
Author: Michael Paquier
Reviewed-by: Robert Haas, Georgios Kokolatos
Discussion: https://postgr.es/m/YlPQGNAAa04raObK@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3603f7c6e66afda7c7bf4acdefd4e5b04c5478b3

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 18 +++----
src/bin/pg_basebackup/pg_receivewal.c | 44 ++++++++--------
src/bin/pg_basebackup/receivelog.c    |  2 +-
src/bin/pg_basebackup/walmethods.c    | 96 +++++++++++++++++------------------
src/bin/pg_basebackup/walmethods.h    | 16 ++----
5 files changed, 84 insertions(+), 92 deletions(-)



Message-ID: <E1neBzQ-0009EK-Ib@gemulon.postgresql.org>
Permalink:  ../E1neBzQ-0009EK-Ib@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1neBzQ-0009EK-Ib@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Remove WalCompressionMethod in favor of pg_compress_algorithm
  In-Reply-To: <E1neBzQ-0009EK-Ib@gemulon.postgresql.org>
  References: <E1neBzQ-0009EK-Ib@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox