pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove not-very-useful early checks of __pg_log_level in logging
Date: Tue, 12 Apr 2022 17:25:36 +0000
Message-ID: <E1neKGm-000CSU-92@gemulon.postgresql.org> (raw)

Remove not-very-useful early checks of __pg_log_level in logging.h.

Enforce __pg_log_level message filtering centrally in logging.c,
instead of relying on the calling macros to do it.  This is more
reliable (e.g. it works correctly for direct calls to pg_log_generic)
and it saves a percent or so of total code size because we get rid of
so many duplicate checks of __pg_log_level.

This does mean that argument expressions in a logging macro will be
evaluated even if we end up not printing anything.  That seems of
little concern for INFO and higher levels as those messages are printed
by default, and most of our frontend programs don't even offer a way to
turn them off.  I left the unlikely() checks in place for DEBUG
messages, though.

Discussion: https://postgr.es/m/3993549.1649449609@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2c9381840fe2d6d1c3179350493fe5fd3dcf90b5

Modified Files
--------------
src/bin/pg_dump/pg_backup_utils.h |  3 +--
src/common/logging.c              |  4 +++
src/include/common/logging.h      | 57 +++++++++++++--------------------------
3 files changed, 24 insertions(+), 40 deletions(-)



Message-ID: <E1neKGm-000CSU-92@gemulon.postgresql.org>
Permalink:  ../E1neKGm-000CSU-92@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1neKGm-000CSU-92@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Remove not-very-useful early checks of __pg_log_level in logging
  In-Reply-To: <E1neKGm-000CSU-92@gemulon.postgresql.org>
  References: <E1neKGm-000CSU-92@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox