pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix case sensitivity in psql's tab completion for GUC names.
Date: Wed, 13 Apr 2022 20:26:46 +0000
Message-ID: <E1nejZe-000NhS-LT@gemulon.postgresql.org> (raw)

Fix case sensitivity in psql's tab completion for GUC names.

Input for these should be case-insensitive, but was not completely
so.  Comparing to the similar queries for timezone names, I realized
that we'd missed forcing the comparison pattern to lower-case.
With that, it behaves as I expect.

While here, flatten the sub-selects in these queries; I don't
find that those add any readability.

Discussion: https://postgr.es/m/3369130.1649348542@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b5607b0746f40b3f5b38004c64ccc9697ee1e222

Modified Files
--------------
src/bin/psql/tab-complete.c | 22 ++++++++--------------
1 file changed, 8 insertions(+), 14 deletions(-)



Message-ID: <E1nejZe-000NhS-LT@gemulon.postgresql.org>
Permalink:  ../E1nejZe-000NhS-LT@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nejZe-000NhS-LT@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix case sensitivity in psql's tab completion for GUC names.
  In-Reply-To: <E1nejZe-000NhS-LT@gemulon.postgresql.org>
  References: <E1nejZe-000NhS-LT@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox