pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pageinspect: Fix handling of all-zero pages
Date: Thu, 14 Apr 2022 06:11:10 +0000
Message-ID: <E1neshC-000RPX-Nw@gemulon.postgresql.org> (raw)

pageinspect: Fix handling of all-zero pages

Getting from get_raw_page() an all-zero page is considered as a valid
case by the buffer manager and it can happen for example when finding a
corrupted page with zero_damaged_pages enabled (using zero_damaged_pages
to look at corrupted pages happens), or after a crash when a relation
file is extended before any WAL for its new data is generated (before a
vacuum or autovacuum job comes in to do some cleanup).

However, all the functions of pageinspect, as of the index AMs (except
hash that has its own idea of new pages), heap, the FSM or the page
header have never worked with all-zero pages, causing various crashes
when going through the page internals.

This commit changes all the pageinspect functions to be compliant with
all-zero pages, where the choice is made to return NULL or no rows for
SRFs when finding a new page.  get_raw_page() still works the same way,
returning a batch of zeros in the bytea of the page retrieved.  A hard
error could be used but NULL, while more invasive, is useful when
scanning relation files in full to get a batch of results for a single
relation in one query.  Tests are added for all the code paths
impacted.

Reported-by: Daria Lepikhova
Author: Michael Paquier
Discussion: https://postgr.es/m/561e187b-3549-c8d5-03f5-525c14e65bd0@postgrespro.ru
Backpatch-through: 10

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cd4868a5700fadf5a840d44686658517433b338c

Modified Files
--------------
contrib/pageinspect/brinfuncs.c        | 22 ++++++++++++++++++++++
contrib/pageinspect/btreefuncs.c       |  6 ++++++
contrib/pageinspect/expected/brin.out  | 25 +++++++++++++++++++++++++
contrib/pageinspect/expected/btree.out |  6 ++++++
contrib/pageinspect/expected/gin.out   | 14 ++++++++++++++
contrib/pageinspect/expected/gist.out  | 18 ++++++++++++++++++
contrib/pageinspect/expected/hash.out  | 12 ++++++++++++
contrib/pageinspect/expected/page.out  | 20 ++++++++++++++++++++
contrib/pageinspect/fsmfuncs.c         |  4 ++++
contrib/pageinspect/ginfuncs.c         | 13 +++++++++++++
contrib/pageinspect/gistfuncs.c        | 12 ++++++++++++
contrib/pageinspect/rawpage.c          |  3 +++
contrib/pageinspect/sql/brin.sql       |  7 +++++++
contrib/pageinspect/sql/btree.sql      |  4 ++++
contrib/pageinspect/sql/gin.sql        |  6 ++++++
contrib/pageinspect/sql/gist.sql       |  6 ++++++
contrib/pageinspect/sql/hash.sql       |  7 +++++++
contrib/pageinspect/sql/page.sql       |  6 ++++++
18 files changed, 191 insertions(+)



view thread (6+ messages)  latest in thread

Message-ID: <E1neshC-000RPX-Nw@gemulon.postgresql.org>
Permalink:  ../E1neshC-000RPX-Nw@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1neshC-000RPX-Nw@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: pageinspect: Fix handling of all-zero pages
  In-Reply-To: <E1neshC-000RPX-Nw@gemulon.postgresql.org>
  References: <E1neshC-000RPX-Nw@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox