pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix second race condition in 002_archiving.pl with archive_clean
Date: Mon, 18 Apr 2022 04:42:59 +0000
Message-ID: <E1ngJE3-0011kV-JU@gemulon.postgresql.org> (raw)

Fix second race condition in 002_archiving.pl with archive_cleanup_command

Checking the execution of archive_cleanup_command on a standby requires
a valid checkpoint coming from its primary, but the logic did not check
that the standby replayed up to the point of the checkpoint, causing the
test checking for the execution of archive_cleanup_command to fail.
This race was more visible in slow environments.

Issue introduced in 46dea24, so no backpatch is needed.

Author: Tom Lane
Discussion: https://postgr.es/m/4015413.1649454951@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1a8b110539efe18803c1fa8aa452a2178dbad9a9

Modified Files
--------------
src/test/recovery/t/002_archiving.pl | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)



Message-ID: <E1ngJE3-0011kV-JU@gemulon.postgresql.org>
Permalink:  ../E1ngJE3-0011kV-JU@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ngJE3-0011kV-JU@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Fix second race condition in 002_archiving.pl with archive_clean
  In-Reply-To: <E1ngJE3-0011kV-JU@gemulon.postgresql.org>
  References: <E1ngJE3-0011kV-JU@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox