pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix breakage in AlterFunction(). 6+ messages / 1 participants [nested] [flat]
* pgsql: Fix breakage in AlterFunction(). @ 2022-04-20 03:04 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-04-20 03:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix breakage in AlterFunction(). An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4f2. (I did not bother with a regression test, because the only likely future breakage would be for someone to ignore the comment I added and add some other field update after the heap_modify_tuple step. A test using existing function properties could not catch that.) Per report from Bryn Llewellyn. Back-patch to all supported branches. Discussion: https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9130f8cbb91954f7a40de70c014c01b552df31da Modified Files -------------- src/backend/commands/functioncmds.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix breakage in AlterFunction(). @ 2022-04-20 03:04 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-04-20 03:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix breakage in AlterFunction(). An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4f2. (I did not bother with a regression test, because the only likely future breakage would be for someone to ignore the comment I added and add some other field update after the heap_modify_tuple step. A test using existing function properties could not catch that.) Per report from Bryn Llewellyn. Back-patch to all supported branches. Discussion: https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/08a9e7a8c7917233926802aaea94a5529a747a50 Modified Files -------------- src/backend/commands/functioncmds.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix breakage in AlterFunction(). @ 2022-04-20 03:04 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-04-20 03:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix breakage in AlterFunction(). An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4f2. (I did not bother with a regression test, because the only likely future breakage would be for someone to ignore the comment I added and add some other field update after the heap_modify_tuple step. A test using existing function properties could not catch that.) Per report from Bryn Llewellyn. Back-patch to all supported branches. Discussion: https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/481a99811a416ebb0e1b3b15628752a00bdca672 Modified Files -------------- src/backend/commands/functioncmds.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix breakage in AlterFunction(). @ 2022-04-20 03:04 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-04-20 03:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix breakage in AlterFunction(). An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4f2. (I did not bother with a regression test, because the only likely future breakage would be for someone to ignore the comment I added and add some other field update after the heap_modify_tuple step. A test using existing function properties could not catch that.) Per report from Bryn Llewellyn. Back-patch to all supported branches. Discussion: https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/344a225cb9d42f20df063e4d0e0d4559c5de7910 Modified Files -------------- src/backend/commands/functioncmds.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix breakage in AlterFunction(). @ 2022-04-20 03:04 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-04-20 03:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix breakage in AlterFunction(). An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4f2. (I did not bother with a regression test, because the only likely future breakage would be for someone to ignore the comment I added and add some other field update after the heap_modify_tuple step. A test using existing function properties could not catch that.) Per report from Bryn Llewellyn. Back-patch to all supported branches. Discussion: https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f583633bc130e8a572e5d29b9c8b2cc48885ecbf Modified Files -------------- src/backend/commands/functioncmds.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix breakage in AlterFunction(). @ 2022-04-20 03:04 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-04-20 03:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix breakage in AlterFunction(). An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4f2. (I did not bother with a regression test, because the only likely future breakage would be for someone to ignore the comment I added and add some other field update after the heap_modify_tuple step. A test using existing function properties could not catch that.) Per report from Bryn Llewellyn. Back-patch to all supported branches. Discussion: https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/409bcfda6bd62479f4f7e745c4a536757dbe9637 Modified Files -------------- src/backend/commands/functioncmds.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2022-04-20 03:04 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-04-20 03:04 pgsql: Fix breakage in AlterFunction(). Tom Lane <tgl@sss.pgh.pa.us> 2022-04-20 03:04 pgsql: Fix breakage in AlterFunction(). Tom Lane <tgl@sss.pgh.pa.us> 2022-04-20 03:04 pgsql: Fix breakage in AlterFunction(). Tom Lane <tgl@sss.pgh.pa.us> 2022-04-20 03:04 pgsql: Fix breakage in AlterFunction(). Tom Lane <tgl@sss.pgh.pa.us> 2022-04-20 03:04 pgsql: Fix breakage in AlterFunction(). Tom Lane <tgl@sss.pgh.pa.us> 2022-04-20 03:04 pgsql: Fix breakage in AlterFunction(). Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox