pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix breakage in AlterFunction().
Date: Wed, 20 Apr 2022 03:04:16 +0000
Message-ID: <E1nh0dc-000CXj-ID@gemulon.postgresql.org> (raw)

Fix breakage in AlterFunction().

An ALTER FUNCTION command that tried to update both the function's
proparallel property and its proconfig list failed to do the former,
because it stored the new proparallel value into a tuple that was
no longer the interesting one.  Carelessness in 7aea8e4f2.

(I did not bother with a regression test, because the only likely
future breakage would be for someone to ignore the comment I added
and add some other field update after the heap_modify_tuple step.
A test using existing function properties could not catch that.)

Per report from Bryn Llewellyn.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9130f8cbb91954f7a40de70c014c01b552df31da

Modified Files
--------------
src/backend/commands/functioncmds.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1nh0dc-000CXj-ID@gemulon.postgresql.org>
Permalink:  ../E1nh0dc-000CXj-ID@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nh0dc-000CXj-ID@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix breakage in AlterFunction().
  In-Reply-To: <E1nh0dc-000CXj-ID@gemulon.postgresql.org>
  References: <E1nh0dc-000CXj-ID@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox