pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use DECLARE_TOAST_WITH_MACRO() to simplify toast-table declarati
Date: Thu, 21 Apr 2022 16:02:31 +0000
Message-ID: <E1nhZGI-000S0S-KA@gemulon.postgresql.org> (raw)

Use DECLARE_TOAST_WITH_MACRO() to simplify toast-table declarations.

This is needed so that renumber_oids.pl can handle renumbering
shared catalog declarations, which need to provide C macros for
the OIDs of the shared toast table and index.  The previous
method of writing a C macro separately was error-prone anyway.

Also teach renumber_oids.pl about DECLARE_UNIQUE_INDEX_PKEY,
as we missed doing when inventing that macro.

There are no changes to postgres.bki here, so no need for a
catversion bump.

Discussion: https://postgr.es/m/2995325.1650487527@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/40eba064b24d98e343b45ccef6907fe8c9784dc1

Modified Files
--------------
src/backend/catalog/Catalog.pm              | 11 +++++++++++
src/backend/catalog/genbki.pl               | 10 ++++++++++
src/include/catalog/genbki.h                |  6 +++++-
src/include/catalog/pg_authid.h             |  4 +---
src/include/catalog/pg_database.h           |  4 +---
src/include/catalog/pg_db_role_setting.h    |  4 +---
src/include/catalog/pg_parameter_acl.h      |  4 +---
src/include/catalog/pg_replication_origin.h |  4 +---
src/include/catalog/pg_shdescription.h      |  4 +---
src/include/catalog/pg_shseclabel.h         |  4 +---
src/include/catalog/pg_subscription.h       |  4 +---
src/include/catalog/pg_tablespace.h         |  4 +---
src/include/catalog/renumber_oids.pl        | 27 +++++++++++++++++++++++----
13 files changed, 58 insertions(+), 32 deletions(-)



Message-ID: <E1nhZGI-000S0S-KA@gemulon.postgresql.org>
Permalink:  ../E1nhZGI-000S0S-KA@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nhZGI-000S0S-KA@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Use DECLARE_TOAST_WITH_MACRO() to simplify toast-table declarati
  In-Reply-To: <E1nhZGI-000S0S-KA@gemulon.postgresql.org>
  References: <E1nhZGI-000S0S-KA@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox