pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Inhibit mingw CRT's auto-globbing of command line arguments
Date: Mon, 25 Apr 2022 19:53:02 +0000
Message-ID: <E1nj4la-0016p0-3G@gemulon.postgresql.org> (raw)

Inhibit mingw CRT's auto-globbing of command line arguments

For some reason by default the mingw C Runtime takes it upon itself to
expand program arguments that look like shell globbing characters. That
has caused much scratching of heads and mis-attribution of the causes of
some TAP test failures, so stop doing that.

This removes an inconsistency with Windows binaries built with MSVC,
which have no such behaviour.

Per suggestion from Noah Misch.

Backpatch to all live branches.

Discussion: https://postgr.es/m/20220423025927.GA1274057@rfd.leadboat.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/71f394667c824257ddf6e8359cba746e621a2d16

Modified Files
--------------
src/common/exec.c | 5 +++++
1 file changed, 5 insertions(+)



view thread (6+ messages)  latest in thread

Message-ID: <E1nj4la-0016p0-3G@gemulon.postgresql.org>
Permalink:  ../E1nj4la-0016p0-3G@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nj4la-0016p0-3G@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net
  Subject: Re: pgsql: Inhibit mingw CRT's auto-globbing of command line arguments
  In-Reply-To: <E1nj4la-0016p0-3G@gemulon.postgresql.org>
  References: <E1nj4la-0016p0-3G@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox