pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove durable_rename_excl()
2+ messages / 1 participants
[nested] [flat]

* pgsql: Remove durable_rename_excl()
@ 2022-04-28 02:12  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 2+ messages in thread

From: Michael Paquier @ 2022-04-28 02:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove durable_rename_excl()

ccfbd92 has replaced all existing in-core callers of this function in
favor of durable_rename().  durable_rename_excl() is by nature unsafe on
crashes happening at the wrong time, so just remove it.

Author: Nathan Bossart
Reviewed-by: Robert Haas, Kyotaro Horiguchi, Michael Paquier
Discussion: https://postgr.es/m/20220407182954.GA1231544@nathanxps13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2c902bbf1911a3c3dd68b817209eca9be81e381c

Modified Files
--------------
src/backend/storage/file/fd.c  | 63 ------------------------------------------
src/include/pg_config_manual.h |  7 -----
src/include/storage/fd.h       |  1 -
3 files changed, 71 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Remove durable_rename_excl()
@ 2022-07-05 03:54  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 2+ messages in thread

From: Michael Paquier @ 2022-07-05 03:54 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove durable_rename_excl()

A previous commit replaced all the calls to this function with
durable_rename() as of dac1ff3, making it used nowhere in the tree.
Using it in extension code is also risky based on the issues described
in this previous commit, so let's remove it.  This makes possible the
removal of HAVE_WORKING_LINK.

Author: Nathan Bossart
Reviewed-by: Robert Haas, Kyotaro Horiguchi, Michael Paquier
Discussion: https://postgr.es/m/20220407182954.GA1231544@nathanxps13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eb64ceac7ec3422f2370b8824dce62ee8fe52dca

Modified Files
--------------
src/backend/storage/file/fd.c  | 63 ------------------------------------------
src/include/pg_config_manual.h |  7 -----
src/include/storage/fd.h       |  1 -
3 files changed, 71 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-07-05 03:54 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-04-28 02:12 pgsql: Remove durable_rename_excl() Michael Paquier <michael@paquier.xyz>
2022-07-05 03:54 pgsql: Remove durable_rename_excl() Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox