pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove durable_rename_excl()
Date: Tue, 05 Jul 2022 03:54:56 +0000
Message-ID: <E1o8ZeJ-001Fp9-Ci@gemulon.postgresql.org> (raw)

Remove durable_rename_excl()

A previous commit replaced all the calls to this function with
durable_rename() as of dac1ff3, making it used nowhere in the tree.
Using it in extension code is also risky based on the issues described
in this previous commit, so let's remove it.  This makes possible the
removal of HAVE_WORKING_LINK.

Author: Nathan Bossart
Reviewed-by: Robert Haas, Kyotaro Horiguchi, Michael Paquier
Discussion: https://postgr.es/m/20220407182954.GA1231544@nathanxps13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eb64ceac7ec3422f2370b8824dce62ee8fe52dca

Modified Files
--------------
src/backend/storage/file/fd.c  | 63 ------------------------------------------
src/include/pg_config_manual.h |  7 -----
src/include/storage/fd.h       |  1 -
3 files changed, 71 deletions(-)



view thread (2+ messages)

Message-ID: <E1o8ZeJ-001Fp9-Ci@gemulon.postgresql.org>
Permalink:  ../E1o8ZeJ-001Fp9-Ci@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1o8ZeJ-001Fp9-Ci@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Remove durable_rename_excl()
  In-Reply-To: <E1o8ZeJ-001Fp9-Ci@gemulon.postgresql.org>
  References: <E1o8ZeJ-001Fp9-Ci@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox