pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert recent changes with durable_rename_excl()
Date: Thu, 28 Apr 2022 04:08:50 +0000
Message-ID: <E1njvSU-001UEu-7u@gemulon.postgresql.org> (raw)

Revert recent changes with durable_rename_excl()

This reverts commits 2c902bb and ccfbd92.  Per buildfarm members
kestrel, rorqual and calliphoridae, the assertions checking that a TLI
history file should not exist when created by a WAL receiver have been
failing, and switching to durable_rename() over durable_rename_excl()
would cause the newest TLI history file to overwrite the existing one.
We need to think harder about such cases, so revert the new logic for
now.

Note that all the failures have been reported in the test
025_stuck_on_old_timeline.

Discussion: https://postgr.es/m/511362.1651116498@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/55b56865115eccd6449e79d6f06fe49d6ba3b792

Modified Files
--------------
contrib/basic_archive/basic_archive.c |  5 ++-
src/backend/access/transam/timeline.c | 18 ++++++----
src/backend/access/transam/xlog.c     | 10 +++---
src/backend/storage/file/fd.c         | 63 +++++++++++++++++++++++++++++++++++
src/include/pg_config_manual.h        |  7 ++++
src/include/storage/fd.h              |  1 +
6 files changed, 91 insertions(+), 13 deletions(-)



Message-ID: <E1njvSU-001UEu-7u@gemulon.postgresql.org>
Permalink:  ../E1njvSU-001UEu-7u@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1njvSU-001UEu-7u@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Revert recent changes with durable_rename_excl()
  In-Reply-To: <E1njvSU-001UEu-7u@gemulon.postgresql.org>
  References: <E1njvSU-001UEu-7u@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox