From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Disallow infinite endpoints in generate_series() for tim
Date: Mon, 09 May 2022 15:41:31 +0000
Message-ID: <E1no5Vq-000lZ2-AT@gemulon.postgresql.org> (raw)
Revert "Disallow infinite endpoints in generate_series() for timestamps."
This reverts commit eafdf9de06e9b60168f5e47cedcfceecdc6d4b5f
and its back-branch counterparts. Corey Huinker pointed out that
we'd discussed this exact change back in 2016 and rejected it,
on the grounds that there's at least one usage pattern with LIMIT
where an infinite endpoint can usefully be used. Perhaps that
argument needs to be re-litigated, but there's no time left before
our back-branch releases. To keep our options open, restore the
status quo ante; if we do end up deciding to change things, waiting
one more quarter won't hurt anything.
Rather than just doing a straight revert, I added a new test case
demonstrating the usage with LIMIT. That'll at least remind us of
the issue if we forget again.
Discussion: https://postgr.es/m/3603504.1652068977@sss.pgh.pa.us
Discussion: https://postgr.es/m/CADkLM=dzw0Pvdqp5yWKxMd+VmNkAMhG=4ku7GnCZxebWnzmz3Q@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/29904f5f2fdafbbb96ef3685fd361053b061aeb1
Modified Files
--------------
src/backend/utils/adt/timestamp.c | 28 ----------------------------
src/test/regress/expected/timestamp.out | 27 +++++++++++++++++++--------
src/test/regress/expected/timestamptz.out | 27 +++++++++++++++++++--------
src/test/regress/sql/timestamp.sql | 11 +++++------
src/test/regress/sql/timestamptz.sql | 11 +++++------
5 files changed, 48 insertions(+), 56 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Revert "Disallow infinite endpoints in generate_series() for tim
In-Reply-To: <E1no5Vq-000lZ2-AT@gemulon.postgresql.org>
References: <E1no5Vq-000lZ2-AT@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox